final changes

SerpentRace_Backend/src/Application/Game/commands/JoinGameCommandHandler.ts

@@ -151,6 +151,15 @@ export class JoinGameCommandHandler {
                 isOnline: true
             };
 
+            // Check if player name is already in use by a different player
+            const existingPlayerWithName = gameData.currentPlayers.find(
+                p => p.playerName === command.playerName && p.playerId !== command.playerId
+            );
+
+            if (existingPlayerWithName) {
+                throw new Error(`Player name "${command.playerName}" is already in use in this game`);
+            }
+
             // Update players list (remove if exists, then add)
             gameData.currentPlayers = gameData.currentPlayers.filter(p => p.playerId !== command.playerId);
             gameData.currentPlayers.push(newPlayer);
@@ -161,9 +170,6 @@ export class JoinGameCommandHandler {
             // Store updated data in Redis with TTL (24 hours)
             await this.redisService.setWithExpiry(redisKey, JSON.stringify(gameData), 24 * 60 * 60);
 
-            // Add player to active players set
-            await this.redisService.setAdd(`active_players:${game.id}`, command.playerId);
-
             logOther('Game data updated in Redis', {
                 gameId: game.id,
                 gameCode: game.gamecode,
@@ -204,7 +210,6 @@ export class JoinGameCommandHandler {
                 gameData.currentPlayers = gameData.currentPlayers.filter(p => p.playerId !== playerId);
                 
                 await this.redisService.setWithExpiry(redisKey, JSON.stringify(gameData), 24 * 60 * 60);
-                await this.redisService.setRemove(`active_players:${gameId}`, playerId);
             }
         } catch (error) {
             logError('Failed to remove player from Redis', error instanceof Error ? error : new Error(String(error)));

SerpentRace_Backend/src/Application/Game/commands/StartGameCommandHandler.ts

@@ -64,7 +64,7 @@ export class StartGameCommandHandler {
                 gamecode,
                 maxplayers: command.maxplayers,
                 logintype: command.logintype,
-                createdby: command.userid || null,
+                createdby: command.userid!,
                 orgid: command.orgid || null,
                 gamedecks,
                 players: [],